Skip to content

Conversation

raphael-geffroy
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Docs? yes
Issues Fix #3039
License MIT

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Sep 18, 2025
@carsonbot carsonbot changed the title docs: e2e contribution documentation docs: e2e contribution documentation Sep 18, 2025
@raphael-geffroy
Copy link
Contributor Author

@Kocal tried to create the requested doc, tell me what I can adjust so it fits with your needs 🙏

@Kocal Kocal self-requested a review as a code owner September 19, 2025 13:00
@Kocal Kocal requested a review from Copilot September 19, 2025 13:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for interactive browser testing by introducing a new test:browser:ui npm script across all UX packages and enhances the documentation to guide contributors on E2E testing workflows.

  • Adds test:browser:ui script to all package.json files for interactive browser testing with Playwright UI
  • Updates contribution documentation with comprehensive E2E testing guidelines
  • Fixes an incorrect import path example in the Playwright base configuration

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.

File Description
Multiple package.json files Added test:browser:ui script for interactive browser testing
CONTRIBUTING.md Added comprehensive E2E testing documentation and clarified unit testing workflow
playwright.config.base.ts Fixed incorrect import path in code example comment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Kocal Kocal force-pushed the docs/e2e-contribution-documentation branch from 277e8b3 to 728d4e5 Compare September 19, 2025 13:02
@Kocal Kocal changed the title docs: e2e contribution documentation [Docs] Add doc for E2E steps + minor modifications Sep 19, 2025
@Kocal Kocal added the Documentation Improvements or additions to documentation label Sep 19, 2025
@carsonbot carsonbot changed the title [Docs] Add doc for E2E steps + minor modifications Add doc for E2E steps + minor modifications Sep 19, 2025
@Kocal Kocal force-pushed the docs/e2e-contribution-documentation branch from 728d4e5 to ceefa1d Compare September 19, 2025 13:06
@Kocal
Copy link
Member

Kocal commented Sep 19, 2025

I did some modifications to make it more "friendly", and also added Unit test section as well.
Thanks for the contribution @raphael-geffroy!

@Kocal Kocal merged commit 405251f into symfony:2.x Sep 19, 2025
33 of 35 checks passed
Kocal added a commit that referenced this pull request Sep 20, 2025
…ultiples checks for packages definition (Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

 Refactor "test_package.sh" to its original purpose, add multiples checks for packages definition

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Following the minor changes from #3086

Commits
-------

4949e62 Refactor "test_package.sh" to its original purpose, add multiples checks for packages definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to run E2E tests locally
3 participants